Add minimum flow rates for spiral vase transitsions #8333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Original PR to PrusaSlicer: |
46a7ed2 to
73469cd
Compare
Currently when starting the spiral vase the extrusion rate is ramped from 0 to 100% on the first layer and from 100% to 0% on the last layer. In some cases it can lead to underextrusion at the beginning and end of the spiral. This change adds minimum flow ratio options for the beginning and the end of the vase. This means that instead of ramping from 0% to 100% it instead ramps from for example 20% to 100%. This issue has been reported in SuperSlicer supermerill/SuperSlicer#4195
73469cd to
f01f9aa
Compare
|
@Noisyfox Done. Though IMO all of the other ratios should be percentages instead however that will obviously not be a simple change. |
Yeah agreed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently when starting the spiral vase the extrusion rate is ramped from 0 to 100% on the first layer and from 100% to 0% on the last layer. In some cases it can lead to underextrusion at the beginning and end of the spiral.
This change adds minimum flow rate options for the beginning and the end of the vase. This means that instead of ramping from 0% to 100% it instead ramps from for example 20% to 100%.
This issue has been reported in SuperSlicer
supermerill/SuperSlicer#4195
Screenshots/Recordings/Graphs
Tests
Created a Spiral Vase slice that is limited by flow rate. Observed Flow Color scheme of the slice to verify that flow rate is now scaled from and to the selected percentage.