Fix strange M73 behaviour, where M73 is still present, even if disabled #8388
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed or reporting wrong progress fix SoftFever#8369
This was referenced Feb 12, 2025
|
Binarys for testing can be downloaded here: |
|
Nice! I just gave your version a try and did not find any M73 commands in the file. Running the appimage for 2004 on pop os. |
|
Hi, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #8369
fix #7269
fix #7341
fix #822
Description
Fix wrong generation of M73. M73 is generated twice. I disabled second occurence (which is sometimes faulty).
If M73 is disabled, there is no more M73 in generated gcode.
Screenshots/Recordings/Graphs
Tests
Compared Gcode generated with original version and fixed version