Skip to content

Conversation

HYzd766
Copy link
Contributor

@HYzd766 HYzd766 commented Jan 21, 2025

new change

@igiannakas
Copy link
Contributor

Can you please provide a description of the PR, any relevant screenshots and tests that you have performed against the change? At the moment we see 215 files changed with little description as to why and what is introduced...

@HYzd766
Copy link
Contributor Author

HYzd766 commented Jan 21, 2025

New filaments about our machine

@bistory
Copy link
Contributor

bistory commented Jan 22, 2025

You are reverting previous changes, I think it's not intentional ;-)

@SoftFever
Copy link
Owner

Hi @HYzd766
A quick heads up.
A quick heads up: I'm refactoring the profile system in OrcaSlicer (#8057) with the aim to reduce the duplication of filament profiles and make maintenance work easier. I can help you update this PR so that it follows the new guidelines. And it can potentially be a reference for other vendors' profiles.

Let me know what you think.

Meanwhile, I want to second @igiannakas's point - it's strongly recommended to have a proper title and description of the changes so that they can be traceable.

@SoftFever
Copy link
Owner

You are reverting previous changes, I think it's not intentional ;-)

By any chance you remember which part you noticed that it reversed?

@bistory
Copy link
Contributor

bistory commented Jan 24, 2025

You are reverting previous changes, I think it's not intentional ;-)

By any chance you remember which part you noticed that it reversed?

Yes, the changes that were pushed in this PR : #7868 (default infill to crosshatch and enable precise walls by default)

@SoftFever SoftFever changed the title new Qidi profile udpates: new filaments etc... Jan 31, 2025
@SoftFever
Copy link
Owner

You are reverting previous changes, I think it's not intentional ;-)

By any chance you remember which part you noticed that it reversed?

Yes, the changes that were pushed in this PR : #7868 (default infill to crosshatch and enable precise walls by default)

Thank you.
Looks like they are in CNY holidays.
I will let them to decide when they want to include these changes again in the future.

I merge this PR first, and will refactor it in a new PR

@SoftFever SoftFever merged commit c217b53 into SoftFever:main Jan 31, 2025
1 check passed
GiacomoGuaresi pushed a commit to gingeradditive/OrcaSlicer that referenced this pull request Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants