Skip to content

Gcode Statistics Panel Fixes #8172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 26, 2025
Merged

Gcode Statistics Panel Fixes #8172

merged 2 commits into from
Jan 26, 2025

Conversation

andrewleek
Copy link
Contributor

Description

This PR fixes the following issues:

  1. Gcode Statistics Panel: open/close state not persistent between slicing: Line Type.... Hide/Show #6021
  2. open/close button width is too wide

Screenshots/Recordings/Graphs

Button_width_incorrect
Button_width_correct

@andrewleek
Gcode Statistics Panel - Persist open/close state
c6b671c 
Bug: On slicing a model, the Statistics Panel would be reset to being open (regardless of if the user had shut it earlier)

Fix: Now on app open the Statistics Panel will be open, but if the user closes it, its state will persist (regardless of slicing again)

SoftFever#6021
@andrewleek
Gcode Statistics Panel - fold/unfold button width fix
8324732 
Issue: The fold/unfold button width is too wide (It seems CalcTextSize is making the button wider than necessary)

Fix: Set the width to a correct fixed value
@Stevetm2
Copy link
Contributor

Stevetm2 commented Jan 25, 2025 •
edited
Loading

Any chance of adding a Gcode output enable/disable button on the panel it gets appended to? It would be vastly more convenient and intuitive for it to be there. Unless this is the same thing, which would be great :) Thanks.

Noisyfox
Noisyfox approved these changes Jan 26, 2025
View reviewed changes
Copy link
Collaborator

@Noisyfox Noisyfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@Noisyfox Noisyfox merged commit 118e14d into SoftFever:main Jan 26, 2025
16 checks passed
@andrewleek
Copy link
Contributor Author

@Noisyfox 👍

@Stevetm2
This applies to the Statistics panel, which sits above the G-code panel. While a button to toggle the visibility of the G-code panel could be added to the Statistics panel, it would not be visible if the Statistics panel itself was collapsed. Additionally, it is also already possible to toggle the G-code panel in the View menu.

@andrewleek andrewleek deleted the bug-fix branch January 26, 2025 11:33
GiacomoGuaresi pushed a commit to gingeradditive/OrcaSlicer that referenced this pull request Feb 8, 2025
@andrewleek @GiacomoGuaresi
Gcode Statistics Panel Fixes (SoftFever#8172)
dca8de6 
* Gcode Statistics Panel - Persist open/close state

Bug: On slicing a model, the Statistics Panel would be reset to being open (regardless of if the user had shut it earlier)

Fix: Now on app open the Statistics Panel will be open, but if the user closes it, its state will persist (regardless of slicing again)

SoftFever#6021

* Gcode Statistics Panel - fold/unfold button width fix

Issue: The fold/unfold button width is too wide (It seems CalcTextSize is making the button wider than necessary)

Fix: Set the width to a correct fixed value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Noisyfox Noisyfox Noisyfox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewleek @Stevetm2 @Noisyfox