Fix issue that support surfaces get filtered out unexpectly #7988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noisyfox
commented
Jan 9, 2025
| #ifdef SLIC3R_DEBUG | ||
| SupportGeneratorLayersPtr layers_sorted = | ||
| #endif // SLIC3R_DEBUG | ||
| generate_support_layers(object, raft_layers, bottom_contacts, top_contacts, intermediate_layers, interface_layers, base_interface_layers); |
There was a problem hiding this comment.
This is the part that fixes the problem. Everything else are changes needed to make the code compile. No logic changes at all EXCEPT this one.
|
This is also one more step towards syncing the support code with BBS. |
GiacomoGuaresi
pushed a commit
to gingeradditive/OrcaSlicer
that referenced
this pull request
Feb 8, 2025
…r#7988) Fix issue that support surfaces get filtered out unexpectly (SoftFever#7935)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7935