Skip to content

Update OrcaSlicer.pot #7949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 8, 2025
Merged

Update OrcaSlicer.pot #7949

merged 6 commits into from
Jan 8, 2025

Conversation

discip
Copy link
Contributor

@discip discip commented Jan 7, 2025

Made sentence a bit clearer.

fixes #7945

@discip
Update OrcaSlicer.pot
8d898fc 
Made sentence a bit clearer.
@Noisyfox
Copy link
Collaborator

Noisyfox commented Jan 7, 2025

Do we need to update the string here as well?

OrcaSlicer/src/libslic3r/PrintConfig.cpp

Lines 3396 to 3399 in d4580e7

def = this->add("slow_down_min_speed", coFloats);
def->label = L("Min print speed");
def->tooltip = L("The minimum printing speed that the printer will slow down to to attempt to maintain the minimum layer time "
"above, when slow down for better layer cooling is enabled.");

@discip
Copy link
Contributor Author

discip commented Jan 7, 2025

Maybe? 😅
The only hit I had searching this sentence was the one I edited.

But for consistency I would definitely say yes. 😊

@discip
Update PrintConfig.cpp
2fbf580 
Made sentence a bit clearer.
@discip
Copy link
Contributor Author

discip commented Jan 7, 2025

@Noisyfox
Done! 😊

@Noisyfox Noisyfox merged commit 7f391bc into SoftFever:main Jan 8, 2025
17 checks passed
@discip discip deleted the patch-1 branch January 8, 2025 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Noisyfox Noisyfox Noisyfox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

There is 2 to in Materials section in the cooling tab this is a typo
2 participants
@discip @Noisyfox