Update Arachne algorithm from PrusaSlicer 2.9 #7819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry-picked from prusa3d/PrusaSlicer@e704d82 Co-authored-by: Lukáš Hejl <hejl.lukas@gmail.com>
…oronoi vertex is inside a corner of a polygon. Cherry-picked from prusa3d/PrusaSlicer@669c931 Co-authored-by: Lukáš Hejl <hejl.lukas@gmail.com>
Cherry-picked from prusa3d/PrusaSlicer@34d9b06 Co-authored-by: Lukáš Hejl <hejl.lukas@gmail.com>
…t a focus point. Cherry-picked from prusa3d/PrusaSlicer@c44ffed Co-authored-by: Lukáš Hejl <hejl.lukas@gmail.com>
…ator Especially in cases when the object is composed only of 2 external perimeters and 1 or 2 internal perimeters, the order of perimeters wasn't optimal and differed from the Classic perimeter generator. That caused unnecessary long travels before the external contour was printed. The ordering of perimeters is slightly inspired by the latest changes in CuraEngine. Cherry-picked from prusa3d/PrusaSlicer@1087508 Co-authored-by: Lukáš Hejl <hejl.lukas@gmail.com>
…g for Arachne generator. The previous implementation during the grouping of perimeters using depth-first searches unnecessarily searched nodes that had no impact on grouping, which significantly increased the search space. Cherry-picked from prusa3d/PrusaSlicer@86309ba Co-authored-by: Lukáš Hejl <hejl.lukas@gmail.com>
Cherry-picked from prusa3d/PrusaSlicer@919740f Co-authored-by: Martin Šach <martin.sachin@gmail.com>
Cherry-picked from prusa3d/PrusaSlicer@6df4891 Co-authored-by: Lukáš Hejl <hejl.lukas@gmail.com>
|
Superstar! I had started porting this a while ago (https://github.com/igiannakas/OrcaSlicer/tree/Arachne-improvement-from-PS) but run into a bug where extrusions where missing that I couldn't correct. I see this doesnt happen with your version! Fantastic work and thank you!! |
|
@Noisyfox |
Fixed |
SoftFever
approved these changes
Jan 6, 2025
|
Do you have example what does it change? What improvement we can find after this PR? |
|
@Noisyfox @SoftFever 2.2 2.3 dev |
|
@Noisyfox @SoftFever 2.2 2.3 dev |
|
Odd... I'll take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits for change details