Fix Devcontainer for ARM Mac #7723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiacomoGuaresi
pushed a commit
to gingeradditive/OrcaSlicer
that referenced
this pull request
Dec 19, 2024
* Update devcontainer.json * Create Dockerfile
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes up
devcontainer.jsonso that it can be used on an ARM Mac. I had pulled down the code and tried to open it up in a dev container, but got hit with errors as there isn't an ARM version ofmcr.microsoft.com/devcontainers/cpp:ubuntu-20.04.The image being used is passed in a build arg so that it can still be defined in
devcontainer.json.Screenshots/Recordings/Graphs
n/a
Tests
I'm now able to open up a dev container on an ARM Mac.