fix: allow build on Fedora >= 40 #7710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
590de68 to
d5e3947
Compare
GiacomoGuaresi
pushed a commit
to gingeradditive/OrcaSlicer
that referenced
this pull request
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fedora 40 and 41 use GNU c++ version 14.2.1 which throws an error compiling OrcaSlicer:
error: template-id not allowed for constructor in C++20To ignore this error
-Wno-error=template-id-cdtorcan be added to the compiler flags.Furthermore Fedora 40 and 41 need an additional package to be installed:
libquadmath-devel. On Fedora 39 this package is not needed, but it exists and does no harm.Tests
A full compile run was carried out on these OS: