Do not create raycaster when loading the gcode preview #7596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technically, we will switch to the preview page automatically after slicing is done. If there are no changes, or if the re-slicing hasn't finished, it's basically a no-op in the load_shell function, if I recall correctly. So, it should be fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview will be rebuilt every time we made any changes to the project, such as moving an object, even when the Preivew page is not shown. Creating raycasters (called from
GCodeViewer::load_shells) is slow when model has lots of triangles, and those raycasters won't be used at all since we can't interact with any model on the Preview page, so those raycasters are useless, and should not be created at all.This should make the GUI more responsive when working with projects that has lots of complicated models.
Further more, should we skip the preview reload entirely if the preview page is not shown?