Update build_deps.yml (check for existing directory tree and skips creation if exists) #7337
Conversation
Fixes "Build on Windows" so an error isn't thrown if the working directories already exist.
|
@SoftFever this PR is very simple. Just added '-p' to a couple of mkdir commands for building Windows deps. |
|
@Noisyfox ... do these changes appear to be correct? Without the "-p", the simple act of making the build directory results in an error if the directory already exists, thereby preventing the deps from being built. |
|
I don't think |
From what I've seen, the YAML files on Github appear to be processed with Linux. There are four other "mkdir -p" instances in the original file, so I just copied that. I tried building the deps numerous times without success, but adding the "-p" did the trick. I Googled for >> "An item with the specified name" "already exists." << and found that it is specific to PowerShell. So that's interesting. But PowerShell doesn't support "-p" for mkdir. |
|
@Noisyfox I think I figured out why adding the "-p" fixed the issue; the argument is invalid in PS, so it didn't attempt to create the directory. I'll correct it a different way and update the PR. Thanks for your help! |
|
@Noisyfox I think everything is working correctly now. Can you or one of the others check it it for approval? Thanks! |
LGTM thanks! Just one little update and I could merge this. |
…eation if exists) (SoftFever#7337) * Update build_deps.yml Fixes "Build on Windows" so an error isn't thrown if the working directories already exist. * Update build_deps.yml * Update build_deps.yml
Fixes "Build on Windows" so an error isn't thrown if the working directories already exist. I simply added "-p" to the mkdir commands.
Screenshots/Recordings/Graphs
Before the change:
Will need testing, but it is a simple change to bring "Build on Windows" in line with the other OS builds.