Skip to content

Add profiles for new printer Eryone Thinker X400 #7365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 5, 2025
Merged

Add profiles for new printer Eryone Thinker X400 #7365

merged 4 commits into from
Jan 5, 2025

Conversation

Eryone
Copy link
Contributor

@Eryone Eryone commented Nov 4, 2024

Description

Add profiles for new printer: Eryone Thinker X400

@Eryone
add printer Eryone Thinker X400
637bb4e 
add printer Eryone Thinker X400
@SoftFever
Copy link
Owner

Hi @Eryone

Thanks for the PR.
Can you take a look at the errors?

@Eryone
Copy link
Contributor Author

Eryone commented Nov 14, 2024

Hi @Eryone

Thanks for the PR. Can you take a look at the errors?

Thanks, I have updated the file.
BTW, is there a quick way to check that error by myself?

robert-LJone
robert-LJone approved these changes Dec 30, 2024 •
edited
Loading
View reviewed changes
@SoftFever
Copy link
Owner

Hi @Eryone
Thanks for the PR. Can you take a look at the errors?

Thanks, I have updated the file. BTW, is there a quick way to check that error by myself?

Yes, you can find the tool and guide here: https://github.com/SoftFever/Orca_tools/releases/tag/1
Meanwhile, the CI/CD test will automatically run for you in the future once this PR is merged

SoftFever
SoftFever approved these changes Jan 5, 2025
View reviewed changes
Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SoftFever SoftFever merged commit 604ded5 into SoftFever:main Jan 5, 2025
1 check passed
@Eryone
Copy link
Contributor Author

Eryone commented Jan 6, 2025

Thank you so much and appreciate your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SoftFever SoftFever SoftFever approved these changes

+1 more reviewer

@robert-LJone robert-LJone robert-LJone approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Eryone @SoftFever @robert-LJone