Skip to content

Conversation

buzzhuzz
Copy link
Contributor

Description

Do not set custom font and colour for checkbox caption labels. Update checkbox caption labels visibility depending on checkbox enabled state

Screenshots/Recordings/Graphs

Original behavior:
Screenshot from 2024-10-29 18-01-54 Screenshot from 2024-10-29 18-01-45 Screenshot from 2024-10-29 18-10-37

Updated behavior:
Screenshot from 2024-10-29 18-01-19 Screenshot from 2024-10-29 18-01-10 Screenshot from 2024-10-29 18-12-11

Tests

Linux with light theme only.

Do not set custom font and colour for checkbox caption lables
Update checkbox caption lables visibility depending on checkbox enabled
state
@buzzhuzz
Copy link
Contributor Author

@Patn1, please check if this PR resolves your issue you've brought up in #7199 (comment)

@Patnnn
Copy link

Patnnn commented Oct 31, 2024

Thank you for tagging me and trying to optimise it. But I cannot really test this because the artefact only contains this PR without your other PR. So I may have to wait until the other is merged.

@buzzhuzz
Copy link
Contributor Author

buzzhuzz commented Nov 1, 2024

Oh, I see. Just pushed merged 7289 and 7199 into my fork https://github.com/buzzhuzz/OrcaSlicer/tree/refs/heads/test/orca-pr7289-validation
You could get binaries to test once the build is complete at https://github.com/buzzhuzz/OrcaSlicer/actions/runs/11621615427

@Patnnn
Copy link

Patnnn commented Nov 1, 2024

Definitely better than before, but I think that its still not perfect.
image

Also it looks worse in dark mode now.
image

I don't know if it's possible, but could it be made like the slicer settings? So that the checkbox also has a white background when its selectable or a grey background when its not?
image

@yw4z
Copy link
Contributor

yw4z commented Aug 23, 2025

i think you can close this one since i did same on #9797
sorry didnt even noticed this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants