Skip to content

Fix crash when doing PA calib using pattern method from calib tab #7248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2024
Merged

Fix crash when doing PA calib using pattern method from calib tab #7248

merged 1 commit into from
Oct 26, 2024

Conversation

Noisyfox
Copy link
Collaborator

Fixes #6028
Fixes #6249
Fixes #7224

SoftFever
SoftFever approved these changes Oct 26, 2024
View reviewed changes
Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix
Thank you

@SoftFever SoftFever merged commit 661efa7 into SoftFever:main Oct 26, 2024
15 checks passed
@Noisyfox Noisyfox deleted the bugfox/calib-pa-crash branch October 26, 2024 14:15
@Hammerfest
Copy link

Hammerfest commented Oct 26, 2024 •
edited
Loading

Should also fix #6128 and #3726
Which are closed stale/not-planned by bot action but same issue with the first being a duplicate and the latter being one of the first reports.
EDIT: in-case you want to close-completed them so the OG posters get updated and can test/confirm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SoftFever SoftFever SoftFever approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Noisyfox @Hammerfest @SoftFever