Skip to content

Conversation

bernarden
Copy link
Contributor

Description

  • Removes Preview overwrite for pre-releases so that Semver can differentiate/compare the versions better.
  • Also removes the logic that tries to find a URL to load in the release notes. This used to cause blank release notes for releases that had 3x ### followed by a URL in the description. v2.2.0-rc is a good example of this.

Screenshots/Recordings/Graphs/Tests

Applied this change to versions 2.1.0 and 2.2.0 beta so I could test both stable and unstable functionality.

2.1.0 Before

Stable finds 2.1.1
image
Unstable finds 2.2.0 beta (Even though beta2 and rc are already released)
image

2.1.0 After

Stable finds 2.1.1
image
Unstable finds 2.0.0 rc
image

2.2.0-beta Before

Stable finds nothing newer
image
Unstable finds nothing newer
image

2.2.0-beta After

Stable finds nothing newer
image
Unstable finds 2.2.0 rc
image
Unstable finds 2.2.0 beta2 when I manually remove 2.2.0 rc from the api response.
image

Copy link
Collaborator

@Noisyfox Noisyfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Noisyfox Noisyfox merged commit ae07f17 into SoftFever:main Dec 1, 2024
15 checks passed
@bernarden bernarden deleted the feature/differentiate-beta-releases-and-always-load-release-notes branch December 2, 2024 09:35
f0x52 pushed a commit to f0x52/OrcaSlicer that referenced this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants