Skip to content

Fix small top/bottom solid infill filtering #6794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 18, 2024
Merged

Fix small top/bottom solid infill filtering #6794

merged 2 commits into from
Sep 18, 2024

Conversation

Noisyfox
Copy link
Collaborator

Fix two issues introduced in PR #6654

  • Use the variable sparse after been std::move-d
  • The order of expand_merge_surfaces() call and the small region filtering block are reversed

This fixes the following bug:
d3bd0367861c18224a90475aac640727

@Noisyfox Noisyfox mentioned this pull request Sep 16, 2024
Merged
SoftFever
SoftFever approved these changes Sep 18, 2024
View reviewed changes
Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks

@SoftFever SoftFever merged commit 47965b0 into SoftFever:main Sep 18, 2024
15 checks passed
@Noisyfox Noisyfox deleted the bugfox/sparse-small-gap branch September 18, 2024 16:33
@Knifa Knifa mentioned this pull request Oct 13, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SoftFever SoftFever SoftFever approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Noisyfox @SoftFever