fix: Continue decapsulation to parse L3 data from VLAN-tagged packets #2140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
what do you think, should we emit new release ? also, if someone is not using vlans, he we'll not notice anything, right ? |
I consider this a "nice-to-have" fix rather than a critical one, as the number of users who rely on both VLAN IDs and packet logging is likely small. I'm happy to leave the decision on whether to merge it to the master branch to your judgment.
That is correct. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses a bug where the ParsePacketL2Ex won't parse Layer 3 packet data when it was encapsulated in a frame with a VLAN tag.
Previously, upon receiving a packet with a VLAN tag, the decapsulation process would not proceed to analyze the inner packet. This prevented the Layer 3 protocol (e.g., IP) from being correctly identified and processed, breaking functionalities that rely on L3 information (packet log for example).
This patch modifies the packet handling logic to ensure that after a VLAN tag is identified, the process continues to decapsulate the rest of the frame, allowing for the proper parsing of the Layer 3 packet within.
The issue I mentioned before #2138