Skip to content

Fix Indonesian translation with printf formatting #2126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 9, 2025
Merged

Fix Indonesian translation with printf formatting #2126

merged 3 commits into from
May 9, 2025

Conversation

kiraware
Copy link
Contributor

@kiraware kiraware commented May 9, 2025

Changes proposed in this pull request:

  • rephrase Indonesian translation that causing stbchecker fail

@kiraware
Copy link
Contributor Author

kiraware commented May 9, 2025

After looking a while, i think there is some logic error for checking stb in Stb.cs file especially when handling ParseTagList(). Maybe this is the cause of indonesian translation is failing.

@kiraware
Copy link
Contributor Author

kiraware commented May 9, 2025

After some try i reveal that if the english string contain % and the other string MUST contain % too. And even it is only print % character, the translated MUST NOT use escape %%. Also you have to make sure that your % dont appear beside another character for example ., , e.g. 80%. or 80%,. The root cause is the code that is trying to check the stb files. Especially this function ParseTagList().

The solution to fix this problem is

  1. Rephrase your translated string
  2. Fix the stbchecker code

I choose the 1 option.

@kiraware
Copy link
Contributor Author

kiraware commented May 9, 2025

@chipitsine Sorry for the errors, on this PR #2124 the action is not fully running on latest commit, hence it doesn't run the stbchecker action. Thus it looks green, but in master branch its fail. Please merge this PR. Sorry for the inconvenience.

Maybe this problem should be created on issue tracker?

@chipitsine chipitsine merged commit 12ed43f into SoftEtherVPN:master May 9, 2025
14 checks passed
@kiraware kiraware deleted the fix-indonesian-translation branch May 9, 2025 06:53
@chipitsine
Copy link
Member

usually it runs on PR branch. but I merged another PR before

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants