Skip to content

build arm and x86 as one tag #2102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 16, 2025
Merged

Conversation

weidi
Copy link
Contributor

@weidi weidi commented Feb 10, 2025

Changes proposed in this pull request:

  • Optimize build and push to just one Github action
  • retire "-arm" tags and publish true multi platform images
  • optimize build to just compile once and leverage layer to all three images, will slim down dockerhub size as well.

@chipitsine
Copy link
Member

are those mutually exclusive ?

image

should we keep only one of them ?

@weidi
Copy link
Contributor Author

weidi commented Feb 10, 2025

The Docker aio builds all images at once and i tried them as matrix so it runs three builds in parallel takes about 32minutes but eats up 3 times more resources compared on the aio as it is now, whereas it heavily relies on caches of the first build so it only has to do it once.

I like the current approach of the aio more as its saving ressources.

If you agree i would go ahead and delete the other workflows to clean up and just have one single docker image CI leftover.

@weidi weidi marked this pull request as draft February 10, 2025 21:21
@chipitsine
Copy link
Member

ok

@chipitsine
Copy link
Member

maybe we can split into several small PRs.

  1. make multiarch builds (i.e. retire arm64 docker repo)
  2. combine images altogether
  3. ...

@chipitsine
Copy link
Member

meanwhile, I'm playing with tagged builds

https://github.com/chipitsine/SoftEtherVPN/actions/runs/13258983341

@weidi
Copy link
Contributor Author

weidi commented Feb 11, 2025

maybe we can split into several small PRs.

  1. make multiarch builds (i.e. retire arm64 docker repo)
  2. combine images altogether
  3. ...

I´d prefer not to rip it apart as its " just" changing the docker-ci and simplify it´s config right away. Also helps to avoid build errors triggering the same issue three times.

@chipitsine
Copy link
Member

please add back "if: ${{ github.repository_owner == 'SoftEtherVPN' }}" guard.
it is ok to comment it in fork, but we'd like to have it in main repo (it will prevent future forks from occasional docker build)

@weidi weidi marked this pull request as ready for review February 16, 2025 16:37
@chipitsine
Copy link
Member

after #2103 is merged (I hope ~30 min), FreeBSD should not be red abymore

@chipitsine chipitsine merged commit b3dfdc2 into SoftEtherVPN:master Feb 16, 2025
11 of 14 checks passed
@chipitsine
Copy link
Member

image

it does not detect tags
if you have and idea, I would appreciate fix.

I'll try to fix myself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants