cpu_features improvements #2092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add USE_SYSTEM_CPU_FEATURES flag to use system's cpu_features instead of the bundled one - Allow the use of cpu_features for more architectures on Linux [1] [1] https://github.com/google/cpu_features/tree/v0.9.0?tab=readme-ov-file#whats-supported
|
I'll fix the rawhide CI failure. |
|
btw, I'm not a big fan of git modules. |
I'd suggest to switch to USE_SYSTEM_CPU_FEATURES where possible |
|
I made this change not to change the current structure and behaviour too much. However, I personally like to switch to the system cpu_features, like libsodium, rather than this approach. I'll raise another PR, let me some time. I'm not sure about Windows BTW. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
[1] https://github.com/google/cpu_features/tree/v0.9.0?tab=readme-ov-file#whats-supported