Skip to content

Adding artifact publishing for Linux #2086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

Mastemmah
Copy link
Contributor

Changes proposed in this pull request:

  • Simple Workflow change to download deb packages created within the Linux workflow

@Mastemmah
Copy link
Contributor Author

I have been using this software for a long time at work and in home applications.
Super project, Keep it up!
It will be easier for everyone to be able to download DEB's without having to build them locally.

@chipitsine
Copy link
Member

not sure whether it is comfortable to download packages from artifacts....
also, Github is known to limit artifacts size (in any case artifacts are not kept longer than 90 days).

I do not mind of deb packages, please get me right.
did you consider Launchpad ppa maybe ?

@Mastemmah
Copy link
Contributor Author

Mastemmah commented Jan 5, 2025

I conclude that the ease of working on a project is a very important factor. 90 days is a lot for projects that are being developed and thanks to this improvement people interested in downloading software to Linux can more easily download it in a working form.

VPN is not highly specialized software, so it is worth considering opening up to users who can't compile packages by hand but would like to try Soft Ether.

I understand your old-school approach, as I come from the old school myself, but I think that making it easier for people to install is a good thing.

Launchpad is a solution only for Ubuntu, meanwhile DEB packages are supported across the debian-based Linux family.
In my opinion, these packages should also be part of the release just as they are for Windows exe files.
Personally, I adhere to the principle that no convenience for home users is bad if it doesn't burden performance. In this case we have such a situation. It is up to you to decide.

And regarding the “old school” factor still enters that creating a PPA or talking to the guys at Canonical or Debian to add Soft Ether to the mainline packages would cost me much more time than this small improvement.

Personally, I have this problem that being in a full-time job it's hard to find time to support open source :( And your project definitely deserves the opportunity to reach a wider audience. If I had so much free time I would love to make a PPA and put it on debian proposed (and maybe I will someday), but at the moment I can only afford cosmetic contributions.

To sum up, I do what I can, but my time is very limited.

@chipitsine
Copy link
Member

can you add some condition to skip those artifacts on pull requests, and leave only for master branch ?

Simple Workflow change to download deb packages created within the Linux workflow
@Mastemmah
Copy link
Contributor Author

@chipitsine added

@chipitsine chipitsine merged commit c2487c6 into SoftEtherVPN:master Jan 7, 2025
3 checks passed
@chipitsine
Copy link
Member

Thank you!

@chipitsine
Copy link
Member

it worked. not sure how comfortable it is from users point of view...

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants