Fix "Not on NT" error message and add uihelp to vpncmd #2033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6e8f4ce to
47b1741
Compare
47b1741 to
128fefc
Compare
|
I've added the fix for the NicCreate error code 31 that I mentioned briefly in the issue. The problem was that vpncmgr.exe starts up a ui helper using the /uihelp argument which handles some functions that it should not be handling. I think vpnclient.exe should be adding in the vlan itself instead of delegating the task to the uihelp process. It doesn't really make sense and seems like bad practice to have the gui doing things that the backend should be able to do. Fixing that issue requires fixing the entire client notification system, so instead I just added the uihelp process to vpncmd.exe as well. |
|
Thanks, I'm going to have a look soon
…On Thu, Aug 15, 2024, 10:43 siddharth-narayan ***@***.***> wrote:
I've added the fix for the NicCreate error code 31 that I mentioned
briefly in the issue. The problem was that vpncmgr.exe starts up a ui
helper using the /uihelp argument which handles some functions that it
should not be handling. I think vpnclient.exe should be adding in the vlan
itself instead of delegating the task to the uihelp process. It doesn't
really make sense and seems like bad practice to have the gui doing things
that the backend should be able to do. Fixing that issue requires fixing
the entire client notification system, so instead I just added the uihelp
process to vpncmd.exe as well.
—
Reply to this email directly, view it on GitHub
<#2033 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAQ5KUCE2SILFWMKHLWOQ2LZRRS2HAVCNFSM6AAAAABLBIVDVWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJQHEYDEMZTGA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
Is there any update? |
|
not yet. sorry |
|
No problem, I don't mind :) |
|
sorry for delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2031
Running vpnclient.exe fails because
ms->IsNtis never set to true. This seems to be old code from the stable branch that was never changed toIsNt().This pull request changes changes
ms->IsNttoIsNt(), and removesIsNtfrom theMSstruct, because it is no longer necessary.