Thumbnail generation improvements #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated the djpeg package to use the netpbm library for decoding. - Enhanced the resize function to avoid unnecessary resizing if the image is already smaller than the target dimensions. - Introduced a two-pass approach in the Get method of the Djpeg struct to optimize image retrieval based on specified dimensions. - Added a new function, getMinimalScale, to determine the optimal scale for resizing images. - Improved the FFmpeg package to include orientation information in the result. - Refactored the goimage package to include a similar resize optimization. - Enhanced the io package to provide a SwapsDimensions method for orientation handling. - Implemented image rotation logic in the sqlite package to handle various orientations based on EXIF data. - Added comprehensive tests for image rotation and thumbnail generation, ensuring correct handling of orientations. - Updated benchmark tests for thumbnail generation to improve performance metrics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved thumbnail generation, adding djpeg support and fixed image orientation handling.
Image Processing Enhancements:
internal/image/indexContents.go,io/sqlite/sqlite.go,io/io.go) [1] [2] [3]Djpegutility, with dynamic scaling based on target dimensions. (io/djpeg/djpeg.go) [1] [2]GetWithSizemethod to allow fetching images with specific dimensions, implemented in several image sources (io/configured/configured.go,io/filtered/filtered.go,io/djpeg/djpeg.go). [1] [2] [3]Dependency Updates:
go.modto use Go 1.23.0 and added support for newer versions of dependencies likegolang.org/x/imageandgolang.org/x/sync. Removed deprecated dependencies (github.com/jbuchbinder/gopnm). (go.mod) [1] [2] [3] [4]pnmdecoding withbmpdecoding in theDjpegutility for better compatibility and performance. (io/djpeg/djpeg.go) [1] [2]Task Configuration:
structtask to analyze struct layouts using thestructlayouttool, improving developer tooling for debugging and optimization. (Taskfile.yml)Thumbnail Generation Improvements:
djpegfor libjpeg-turbo decoding and adjusted configurations for better handling of resized images. (defaults.yaml)FFmpegthumbnail generation to include image orientation metadata. (io/ffmpeg/ffmpeg.go)These changes collectively improve the functionality, maintainability, and performance of the codebase, particularly in image processing and development tooling.