URL-Generation fix, remove die() #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 15, 2015 20:20
The die() in userInfo.php made it possible for the complete page to stop working without the option for displaying a error message. Librarys should never die() in cases where it is out of the control of the developer.
SmItH197
added a commit
that referenced
this pull request
Jul 17, 2015
URL-Generation fix, remove die()
|
@MustiQue33 I highly doubt this has anything to do with this PR, as it's already been merged. edit: he deleted his comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The die() in userInfo.php made it possible for the complete page to stop
working without the option for displaying a error message. Librarys
should never die() in cases where it is out of the control of the
developer.