Skip to content

Add automatic confirmation for flatpak #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 9, 2023
Merged

Add automatic confirmation for flatpak #170

merged 2 commits into from
Oct 9, 2023

Conversation

zeczen
Copy link
Contributor

@zeczen zeczen commented Oct 9, 2023

Adding automatic confirmation for flatpak.

On my fedora machine, when the flatpak package "app.getclipboard.Clipboard" installation is starting, the installation led to automatic "n" response, causing the installation to abort.
Screencast from 2023-10-10 00-09-38.webm

➜  ~ curl -sSL https://github.com/Slackadays/Clipboard/raw/main/install.sh | sh
Searching for a package manager...
Looking for matches…

app.getclipboard.Clipboard permissions:
    ipc       fallback-x11         pulseaudio      wayland
    x11       file access [1]

    [1] host, xdg-run/Clipboard


        ID                             Branch     Op     Remote      Download
 1.     app.getclipboard.Clipboard     stable     i      flathub     < 1.1 MB

Proceed with these changes to the system installation? [Y/n]: n

Automatic confirmation using the -y flag, prevents such interruptions and ensuring a smooth installation process.

@codecov
Copy link

codecov bot commented Oct 9, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (9dff27c) 70.82% compared to head (d2522f3) 71.68%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #170      +/-   ##
==========================================
+ Coverage   70.82%   71.68%   +0.86%     
==========================================
  Files          76       43      -33     
  Lines        4870     4160     -710     
==========================================
- Hits         3449     2982     -467     
+ Misses       1421     1178     -243

see 41 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Slackadays
Copy link
Owner

Thanks! :)

@Slackadays Slackadays merged commit 2471bb0 into Slackadays:main Oct 9, 2023
@BrewTestBot BrewTestBot mentioned this pull request Dec 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zeczen @Slackadays