Skip to content

[NO JIRA] Upgrade foundations dependencies #3886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2025
Merged

[NO JIRA] Upgrade foundations dependencies #3886

merged 1 commit into from
Jul 18, 2025

Conversation

Supremeyh
Copy link
Contributor

@Supremeyh Supremeyh commented Jul 17, 2025 •
edited
Loading

Upgrade foundations dependencies by run upgrade-foundations

  • @skyscanner/bpk-foundations-web from 19.5.0 to 22.1.0
  • @skyscanner/bpk-svgs from 20.6.0 to 20.8.0
    • it would Update beach icon and Add temperature icon.

Remember to include the following changes:

  • Ensure the PR title includes the name of the component you are changing so it's clear in the release notes for consumers of the changes in the version e.g [Clover-123][BpkButton] Updating the colour
  • README.md (If you have created a new component)
  • Component README.md
  • Tests
  • Accessibility tests
    • The following checks were performed:
      • Ability to navigate using a keyboard only
      • Zoom functionality (Deque University explanation):
        • The page SHOULD be functional AND readable when only the text is magnified to 200% of its initial size
        • Pages must reflow as zoom increases up to 400% so that content continues to be presented in only one column i.e. Content MUST NOT require scrolling in two directions (both vertically and horizontally)
      • Ability to navigate using a screen reader only
  • Storybook examples created/updated
  • For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

@Copilot Copilot AI review requested due to automatic review settings July 17, 2025 11:12
@Supremeyh Supremeyh added dependencies Pull requests that update a dependency file minor Non breaking change labels Jul 17, 2025
Copilot
Copilot AI reviewed Jul 17, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades two key Skyscanner foundations dependencies to their latest versions. The changes update both the production and development dependency references to maintain consistency across the project.

  • Upgrades @skyscanner/bpk-foundations-web from version 19.5.0 to 22.1.0
  • Upgrades @skyscanner/bpk-svgs from version 20.6.0 to 20.8.0

Reviewed Changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.

File Description
packages/package.json Updates production dependencies for foundations and SVGs
package.json Updates development dependencies for foundations and SVGs
Files not reviewed (1)
  • packages/package-lock.json: Language not supported

@skyscanner-backpack-bot
Copy link

Visit https://backpack.github.io/storybook-prs/3886 to see this build running in a browser.

Supremeyh
Supremeyh commented Jul 18, 2025
View reviewed changes
package.json
@@ -121,8 +121,8 @@
"@babel/register": "^7.27.1",
"@percy/cli": "^1.31.0",
"@percy/storybook": "^6.0.3",
"@skyscanner/bpk-foundations-web": "^19.5.0",
"@skyscanner/bpk-svgs": "^20.6.0",
"@skyscanner/bpk-foundations-web": "^22.1.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add text-success color token to foundations
Skyscanner/backpack-foundations#463

Supremeyh
Supremeyh commented Jul 18, 2025
View reviewed changes
package.json
"@skyscanner/bpk-foundations-web": "^19.5.0",
"@skyscanner/bpk-svgs": "^20.6.0",
"@skyscanner/bpk-foundations-web": "^22.1.0",
"@skyscanner/bpk-svgs": "^20.8.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update bpk-svgs as well,it would update beach icon and Add temperature icon.

image image

Faye-Xiao
Faye-Xiao approved these changes Jul 18, 2025
View reviewed changes
Copy link
Contributor

@Faye-Xiao Faye-Xiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Supremeyh Supremeyh merged commit acfc287 into main Jul 18, 2025
12 checks passed
@Supremeyh Supremeyh deleted the ez/clover-450_bump_foundations branch July 18, 2025 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@Faye-Xiao Faye-Xiao Faye-Xiao approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file minor Non breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Supremeyh @Faye-Xiao