-
Notifications
You must be signed in to change notification settings - Fork 203
[maintainence] upgrade node to 22.x #3876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Visit https://backpack.github.io/storybook-prs/3876 to see this build running in a browser. |
Visit https://backpack.github.io/storybook-prs/3876 to see this build running in a browser. |
Visit https://backpack.github.io/storybook-prs/3876 to see this build running in a browser. |
Percy failed due to the flaky tests. |
"node": ">=18.20.4", | ||
"npm": ">=10.7.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to change it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I see there is a guideline that we should keep at a lower supported version to reduce friction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the equivalent of lts/hydrogen
. The production recommendation stable is 22.14.0
, and we use the previous version for the minimum Limit. This is also to make it consistent with the Global component and the internal consumer microsite.
@@ -1 +1 @@ | |||
lts/hydrogen | |||
22.14.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use lts/jod for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No strong need for this. Let's make it consistent with the global component first.
Visit https://backpack.github.io/storybook-prs/3876 to see this build running in a browser. |
Remember to include the following changes:
[Clover-123][BpkButton] Updating the colour
README.md
(If you have created a new component)README.md