Skip to content

[maintainence] upgrade node to 22.x #3876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 16, 2025
Merged

[maintainence] upgrade node to 22.x #3876

merged 4 commits into from
Jul 16, 2025

Conversation

Faye-Xiao
Copy link
Contributor

Remember to include the following changes:

  • Ensure the PR title includes the name of the component you are changing so it's clear in the release notes for consumers of the changes in the version e.g [Clover-123][BpkButton] Updating the colour
  • README.md (If you have created a new component)
  • Component README.md
  • Tests
  • Accessibility tests
    • The following checks were performed:
      • Ability to navigate using a keyboard only
      • Zoom functionality (Deque University explanation):
        • The page SHOULD be functional AND readable when only the text is magnified to 200% of its initial size
        • Pages must reflow as zoom increases up to 400% so that content continues to be presented in only one column i.e. Content MUST NOT require scrolling in two directions (both vertically and horizontally)
      • Ability to navigate using a screen reader only
  • Storybook examples created/updated
  • For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

@Faye-Xiao Faye-Xiao added the major Breaking change label Jul 10, 2025
@skyscanner-backpack-bot
Copy link

Visit https://backpack.github.io/storybook-prs/3876 to see this build running in a browser.

@Faye-Xiao Faye-Xiao closed this Jul 10, 2025
@Faye-Xiao Faye-Xiao reopened this Jul 10, 2025
@skyscanner-backpack-bot
Copy link

Visit https://backpack.github.io/storybook-prs/3876 to see this build running in a browser.

@skyscanner-backpack-bot
Copy link

Visit https://backpack.github.io/storybook-prs/3876 to see this build running in a browser.

@Faye-Xiao
Copy link
Contributor Author

Percy failed due to the flaky tests.

@Faye-Xiao Faye-Xiao added the V38 Planned this change in V38 version label Jul 10, 2025
Comment on lines +7 to +8
"node": ">=18.20.4",
"npm": ">=10.7.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to change it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I see there is a guideline that we should keep at a lower supported version to reduce friction

Copy link
Contributor Author

@Faye-Xiao Faye-Xiao Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the equivalent of lts/hydrogen. The production recommendation stable is 22.14.0, and we use the previous version for the minimum Limit. This is also to make it consistent with the Global component and the internal consumer microsite.

@@ -1 +1 @@
lts/hydrogen
22.14.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use lts/jod for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No strong need for this. Let's make it consistent with the global component first.

@skyscanner-backpack-bot
Copy link

Visit https://backpack.github.io/storybook-prs/3876 to see this build running in a browser.

@Faye-Xiao Faye-Xiao merged commit e3d4dbf into main Jul 16, 2025
10 checks passed
@Faye-Xiao Faye-Xiao deleted the upgrade_node_config branch July 16, 2025 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Breaking change V38 Planned this change in V38 version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants