Skip to content

Conversation

KathyWang0208
Copy link
Contributor

@KathyWang0208 KathyWang0208 commented Jun 23, 2025

The content and implementation from BpkPriceMarkerV2 have been merged into the original BpkPriceMarker component. As a result, BpkPriceMarkerV2 has been removed.

This is a breaking change, but only hotels-website uses the component. Since our squad owns the repo, the impact is limited and managed.
image

Remember to include the following changes:

  • Ensure the PR title includes the name of the component you are changing so it's clear in the release notes for consumers of the changes in the version e.g [Clover-123][BpkButton] Updating the colour
  • README.md (If you have created a new component)
  • Component README.md
  • Tests
  • Accessibility tests
    • The following checks were performed:
      • Ability to navigate using a keyboard only
      • Zoom functionality (Deque University explanation):
        • The page SHOULD be functional AND readable when only the text is magnified to 200% of its initial size
        • Pages must reflow as zoom increases up to 400% so that content continues to be presented in only one column i.e. Content MUST NOT require scrolling in two directions (both vertically and horizontally)
      • Ability to navigate using a screen reader only
  • Storybook examples created/updated
  • For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

@KathyWang0208 KathyWang0208 changed the title [BD-9901]Update [BpkPriceMarkerV2] Rename BpkPriceMarkerV2 as BpkPriceMarker [BD-9901][BpkPriceMarkerV2][BpkPriceMarker] Rename BpkPriceMarkerV2 as BpkPriceMarker and remove original BpkPriceMarker Jun 23, 2025
@KathyWang0208 KathyWang0208 added the major Breaking change label Jun 23, 2025
@skyscanner-backpack-bot
Copy link

Visit https://backpack.github.io/storybook-prs/3856 to see this build running in a browser.

@KathyWang0208 KathyWang0208 requested a review from LuoTuxiu June 23, 2025 08:58
@skyscanner-backpack-bot
Copy link

skyscanner-backpack-bot bot commented Jun 23, 2025

Browser support

If this is a visual change, make sure you've tested it in multiple browsers.

Generated by 🚫 dangerJS against bd88a08

@KathyWang0208 KathyWang0208 changed the title [BD-9901][BpkPriceMarkerV2][BpkPriceMarker] Rename BpkPriceMarkerV2 as BpkPriceMarker and remove original BpkPriceMarker [BD-9901][BpkPriceMarkerV2][BpkPriceMarker] replace BpkPriceMarker content with BpkPriceMarkerV2 and remove BpkPriceMarkerV2 Jun 23, 2025
@skyscanner-backpack-bot
Copy link

Visit https://backpack.github.io/storybook-prs/3856 to see this build running in a browser.

@skyscanner-backpack-bot
Copy link

Visit https://backpack.github.io/storybook-prs/3856 to see this build running in a browser.

Copy link
Contributor

@kerrie625 kerrie625 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As breaking-changes, this breaking change does not require consumers to make many modifications or its usages (only hotel-website)are limited (around 5-10 usages across Skyscanner web repositories), it will not need to follow a deprecation cycle. 
Migrating doc have been added.
Let’s wait for the next major release to merge this.

@Faye-Xiao Faye-Xiao added the V38 Planned this change in V38 version label Jul 9, 2025
@skyscanner-backpack-bot
Copy link

Visit https://backpack.github.io/storybook-prs/3856 to see this build running in a browser.

@skyscanner-backpack-bot
Copy link

Visit https://backpack.github.io/storybook-prs/3856 to see this build running in a browser.

@skyscanner-backpack-bot
Copy link

Visit https://backpack.github.io/storybook-prs/3856 to see this build running in a browser.

@Faye-Xiao Faye-Xiao merged commit 02da814 into main Jul 16, 2025
10 checks passed
@Faye-Xiao Faye-Xiao deleted the BD-9901-replace-BpkPriceMarker-with-BpkPriceMarkerV2 branch July 16, 2025 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Breaking change V38 Planned this change in V38 version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants