-
Notifications
You must be signed in to change notification settings - Fork 203
[BD-9901][BpkPriceMarkerV2][BpkPriceMarker] replace BpkPriceMarker content with BpkPriceMarkerV2 and remove BpkPriceMarkerV2 #3856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BD-9901][BpkPriceMarkerV2][BpkPriceMarker] replace BpkPriceMarker content with BpkPriceMarkerV2 and remove BpkPriceMarkerV2 #3856
Conversation
Visit https://backpack.github.io/storybook-prs/3856 to see this build running in a browser. |
Visit https://backpack.github.io/storybook-prs/3856 to see this build running in a browser. |
Visit https://backpack.github.io/storybook-prs/3856 to see this build running in a browser. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As breaking-changes, this breaking change does not require consumers to make many modifications or its usages (only hotel-website)are limited (around 5-10 usages across Skyscanner web repositories), it will not need to follow a deprecation cycle.
Migrating doc have been added.
Let’s wait for the next major release to merge this.
Visit https://backpack.github.io/storybook-prs/3856 to see this build running in a browser. |
Visit https://backpack.github.io/storybook-prs/3856 to see this build running in a browser. |
Visit https://backpack.github.io/storybook-prs/3856 to see this build running in a browser. |
The content and implementation from
BpkPriceMarkerV2
have been merged into the originalBpkPriceMarker
component. As a result,BpkPriceMarkerV2
has been removed.This is a breaking change, but only hotels-website uses the component. Since our squad owns the repo, the impact is limited and managed.

Remember to include the following changes:
[Clover-123][BpkButton] Updating the colour
README.md
(If you have created a new component)README.md