[NO JIRA]: Update font-family-base to include Noto fallbacks #469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the base font family token to include Noto font fallbacks for languages that Skyscanner Relative cannot support, aligning with Backpack's typography documentation.
Key changes:
- Adds Noto font family fallbacks to the base font family token
- Updates consistent across all token format files (SCSS, JSON, JavaScript)
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/bpk-foundations-web/tokens/base.scss | Updates SCSS variable with Noto fallbacks |
| packages/bpk-foundations-web/tokens/base.raw.json | Updates JSON token definition with Noto fallbacks |
| packages/bpk-foundations-web/tokens/base.es6.js | Updates ES6 export with Noto fallbacks |
| packages/bpk-foundations-web/tokens/base.default.scss | Updates default SCSS variable with Noto fallbacks |
| packages/bpk-foundations-web/tokens/base.common.js | Updates CommonJS export with Noto fallbacks |
| packages/bpk-foundations-web/src/base/typography.json | Updates source JSON definition with Noto fallbacks |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
xiaogliu
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the Backpack docs: https://www.skyscanner.design/latest/foundations/typography/fallback-fonts-Fx8gulTr - Skyscanner Relative should have fallbacks of Noto for languages that it cannot support.
When we added Larken and the Noto fallbacks we missed out updating the base font family token to include Noto, this PR does exactly that!
Remember to include the following changes:
README.md