[DON-1958] Add missing spacing tokens for Android and iOS #468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b7ebb64 to
955c67b
Compare
|
Tested on iOS backpack, this doesn't break the build of backpack everything is fine. However the new spaces aren't recognized by the scripts. Need to update them to be able to see these new values in backpack. Ticket here: https://skyscanner.atlassian.net/browse/DON-1974 |
|
This has been fixed on iOS now, we are ready for the merge on our end so can approve on iOS side. Will need approval for android |
5 tasks
henrik-sky
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds additional spacing values that we missing for Android and iOS
Remember to include the following changes:
README.md