[CLOVER-481] Add text-success color token to foundations #463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds a new semantic “text-success” color token for both day and night modes across web, iOS, and Android foundations.
- Introduces
$bpk-text-success-dayand$bpk-text-success-nightin SCSS and default SCSS. - Adds corresponding raw JSON entries and JS exports for web, iOS, and Android.
- Updates common tokens (
.json) and common JS modules to expose the new token.
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/bpk-foundations-web/tokens/base.scss | Added SCSS variables for text-success tokens (day/night) |
| packages/bpk-foundations-web/tokens/base.raw.json | Added raw JSON entries for TEXT_SUCCESS_DAY / TEXT_SUCCESS_NIGHT |
| packages/bpk-foundations-web/tokens/base.es6.js | Exported textSuccessDay and textSuccessNight constants |
| packages/bpk-foundations-web/tokens/base.default.scss | Added default SCSS tokens for success colors |
| packages/bpk-foundations-web/tokens/base.common.js | Included new common JS tokens for success colors |
| packages/bpk-foundations-ios/tokens/base.raw.ios.json | Added iOS raw tokens and grouped semantic success color |
| packages/bpk-foundations-ios/tokens/base.ios.json | Inserted iOS JSON entries for textSuccessDay and textSuccessNight |
| packages/bpk-foundations-common/base/colors/text.json | Added common semantic values TEXT_SUCCESS_DAY / TEXT_SUCCESS_NIGHT |
| packages/bpk-foundations-android/tokens/base.raw.android.json | Added Android raw tokens and semantic color grouping |
Comments suppressed due to low confidence (1)
packages/bpk-foundations-web/tokens/base.es6.js:68
- Add unit tests to verify the new
textSuccessNightandtextSuccessDayexports are present and match their expected values.
export const textSuccessNight = "rgb(98, 241, 198)";
Faye-Xiao
approved these changes
Jul 17, 2025
|
Replied from @EmmanuelBuraimo (design-system-app-gf) in slack: It looks good to me as well, feel free to add me as a reviewer or just use my message here as a confirmation |
EmmanuelBuraimo
approved these changes
Jul 17, 2025
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Add text-success color token to foundations, including
textSuccessDayandtextSuccessNight.Adds corresponding raw JSON entries and JS exports for web, iOS, and Android.
Updates common tokens (.json) and common JS modules to expose the new token.
Remember to include the following changes:
README.md