Donburi/don 1791 remove deprecated static tokens add shadowColor #462
Conversation
There was a problem hiding this comment.
Pull Request Overview
Removes deprecated static tokens (white, sky-blue, black, and deprecated touchable tokens) from Foundation token definitions across web, iOS, Android, and common packages.
- Deleted hard-coded color token definitions in SCSS, JS, and JSON formats.
- Cleaned up iOS & Android raw token JSON by removing deprecated color and touchable entries.
- Updated common alias ordering and removed obsolete props.
Reviewed Changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/bpk-foundations-web/tokens/base.scss | Removed deprecated $bpk-color-white, -sky-blue, -black |
| packages/bpk-foundations-web/tokens/base.raw.json | Dropped COLOR_WHITE, COLOR_SKY_BLUE, COLOR_BLACK |
| packages/bpk-foundations-web/tokens/base.es6.js | Deleted colorWhite, colorSkyBlue, colorBlack exports |
| packages/bpk-foundations-web/tokens/base.default.scss | Removed default SCSS vars for deprecated colors |
| packages/bpk-foundations-web/tokens/base.common.js | Removed deprecated color entries from Common JS export |
| packages/bpk-foundations-ios/tokens/base.raw.ios.json | Cleaned raw iOS JSON of deprecated color/touchable tokens |
| packages/bpk-foundations-ios/tokens/base.ios.json | Removed deprecated entries from compiled iOS JSON |
| packages/bpk-foundations-ios/src/base/touchables.json | Deleted deprecated touchable props |
| packages/bpk-foundations-ios/src/base/box-shadows.json | Added missing newline |
| packages/bpk-foundations-common/base/colors/base.json | Removed legacy color props |
| packages/bpk-foundations-common/base/colors/aliases.json | Reordered SKY_GRAY alias |
| packages/bpk-foundations-android/tokens/base.raw.android.json | Removed deprecated color props |
Comments suppressed due to low confidence (1)
| /// @group colors | ||
| $bpk-color-sky-blue: rgb(0, 98, 227); | ||
| /// @group colors | ||
| $bpk-color-black: rgb(1, 9, 19); |
There was a problem hiding this comment.
I had a quick look at these 3 colour tokens and noticed they're still used in Backpack Web. It seems you're deprecating these 3 color tokens. Is it a known decision for both web and app?
There was a problem hiding this comment.
Will look into this, this shouldn't be removed for web
There was a problem hiding this comment.
Should be good now
There was a problem hiding this comment.
Might just need to check out those Web changes, you can solve them for web by just copying these removed tokens and placing them in the props part here: https://github.com/Skyscanner/backpack-foundations/blob/main/packages/bpk-foundations-web/src/base/fork/colors.json#L44
This linked file above is a fork of the colours which can remain whilst plans are put together to eventually remove them but doesn't block apps from removing them
Ticket: DON-1791
Removing static deprecated tokens
Added new shadowColor token to replace static shadows
Remember to include the following changes:
README.md