[MUON-1044] Update weight in typography.json
#460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new FONT_WEIGHT_BLACK (900) font weight and applies it to the Hero 5 text token across platforms.
- Defines
FONT_WEIGHT_BLACKin raw token files and removes the duplicate entry. - Updates
TEXT_HERO-5_FONT_WEIGHTto use the new black weight in iOS, Android, and the common app typography. - Adds
FONT_WEIGHT_BLACKto the commontypography.json.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/bpk-foundations-ios/tokens/base.raw.ios.json | Adds new FONT_WEIGHT_BLACK and removes duplicate entry |
| packages/bpk-foundations-ios/tokens/base.ios.json | Updates textHero5FontWeight to use black (900) |
| packages/bpk-foundations-common/app/typography.json | Adds FONT_WEIGHT_BLACK and updates TEXT_HERO-5_FONT_WEIGHT |
| packages/bpk-foundations-android/tokens/base.raw.android.json | Adds new FONT_WEIGHT_BLACK and removes duplicate entry |
Comments suppressed due to low confidence (3)
packages/bpk-foundations-common/app/typography.json:33
- Please update the project README (e.g., token reference section) to include the new FONT_WEIGHT_BLACK token.
"FONT_WEIGHT_BLACK": "900"
packages/bpk-foundations-common/app/typography.json:377
- Add or update unit tests to verify that
TEXT_HERO-5_FONT_WEIGHTcorrectly resolves to900.
"value": "{!FONT_WEIGHT_BLACK}",
packages/bpk-foundations-common/app/typography.json:377
- [nitpick] Update or create Storybook examples to show the Hero 5 text rendered with the new black font weight.
"value": "{!FONT_WEIGHT_BLACK}",
|
Tanks for the review @Faye-Xiao , who can support for merging this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Black (900) font weight for the
Hero 5text token in appsRemember to include the following changes:
README.md