[CLOV289][Fix Alert]Replace gulp-jsonlint with eslint #446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
April 22, 2025 18:17
GCpigsic
reviewed
Jun 4, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This pull request removes the outdated gulp-jsonlint dependency and replaces it with ESLint for JSON linting. Key changes include:
- Updating gulpfiles for Web, iOS, and Android to replace gulp-jsonlint with exec-based ESLint calls.
- Adjusting JSON files to remove trailing commas for valid JSON.
- Modifying package.json and ESLint configuration to support JSON linting.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/bpk-foundations-web/gulpfile.mjs | Replaced gulp-jsonlint with ESLint-based linting task. |
| packages/bpk-foundations-ios/gulpfile.mjs | Replaced gulp-jsonlint with ESLint-based linting task. |
| packages/bpk-foundations-android/gulpfile.mjs | Replaced gulp-jsonlint with ESLint-based linting task. |
| packages/bpk-foundations-common/base/colors/*.json | Removed trailing commas for JSON validity. |
| package.json | Updated lint scripts and dependencies to include JSON linting. |
| .eslintrc.json | Added JSON file override rules for ESLint. |
Comments suppressed due to low confidence (1)
package.json:30
- Ensure the updated lint script for JSON files integrates seamlessly with the existing linting workflows and tooling.
"lint": "npm run lint:js && npm run lint:scss && npm run lint:json",
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket Link:
https://skyscanner.atlassian.net/browse/CLOV-289?atlOrigin=eyJpIjoiMjQwMGViYjU5OWI5NGVlN2E4ZjI5NmViN2FhMjVjNDQiLCJwIjoiaiJ9
Problem:
gulp-jsonlintis too old and doesn't support new versions anymoregulp-jsonlintcannot be updated ,but transitive dependency underscore 1.6.0 is introducedSolution:
Why not gulp-eslint:
Remember to include the following changes:
README.md