Skip to content

Conversation

Supremeyh
Copy link
Contributor

@Supremeyh Supremeyh commented May 14, 2025

In last PR we add-bpk-icon-size-lg , and we received some feedback for BPK rating star that - We recently requested the creation of extra large interactive stars in this thread but noticed the newly implemented stars are only at 32px though we wanted it be 48px (including padding) - is there a reason for this / am I using the wrong prop (extraLarge)? https://skyscanner.slack.com/archives/C0JHPDSSU/p1747132680998619

Remember to include the following changes:

  • README.md
  • Tests
  • Storybook examples created/updated for changes to tokens and icons

@Supremeyh Supremeyh added minor minor patch and removed minor minor labels May 14, 2025
Copy link
Contributor

@senzg senzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Supremeyh Supremeyh merged commit 6febd85 into main May 14, 2025
6 of 7 checks passed
@Supremeyh Supremeyh deleted the cl/clover-239_update_icon_size_xl branch May 14, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants