Skip to content

Added log line when new block header is seen #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Added log line when new block header is seen #22

wants to merge 2 commits into from

Conversation

pieterjm
Copy link

blah

@Sjors Sjors changed the title Added log line when new block hash is seen Added log line when new block header is seen Oct 10, 2023
@Sjors
Copy link
Owner

Sjors commented Oct 10, 2023

Concept ACK

Approach NACK. This open a DoS vector where an attacker can flood your logs by sending the same header over and over again.

@pieterjm pieterjm force-pushed the 2023/10/log-saw-new-hash branch from efcda72 to 22d3478 Compare October 10, 2023 11:46
@pieterjm pieterjm force-pushed the 2023/10/log-saw-new-hash branch from 22d3478 to ac43faa Compare October 10, 2023 12:08
@Sjors Sjors closed this Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pieterjm @Sjors