Stratum v2 connman #50
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 19, 2024
|
@pinheadmz wrote in the original PR:
I plan to take a look at this. |
This was referenced Jul 19, 2024
3cf779b to
b549fd6
Compare
bdc8542 to
199234a
Compare
b549fd6 to
22d033c
Compare
199234a to
922fd8a
Compare
22d033c to
6b5ee20
Compare
|
CMake rebase. |
6b5ee20 to
4f957ee
Compare
922fd8a to
50b6eb8
Compare
4f957ee to
b69544c
Compare
50b6eb8 to
6a02367
Compare
b69544c to
1ca68d2
Compare
6a02367 to
ce4269c
Compare
1ca68d2 to
b578e0a
Compare
8220337 to
5fca2c5
Compare
b578e0a to
489c9fb
Compare
5fca2c5 to
dfb9a6d
Compare
489c9fb to
a55fa83
Compare
|
Rebased to move everything into a |
7d5d5ad to
de05710
Compare
|
I switched to @pinheadmz's lite version of SockMan for now: bitcoin#32747 |
21324f0 to
b62f820
Compare
|
I made |
b62f820 to
5a6d2b3
Compare
Introduce a new low-level socket managing class `SockMan`. BindListenPort() is copied from CConnMan in net.cpp and will be modernized in the next commit. Unit-test it with a new class `SocketTestingSetup` which mocks `CreateSock()` and will enable mock client I/O in future commits. `SockMan` and `SocketTestingSetup` are designed to be generic and reusbale for higher-level network protocol implementation and testing. Co-authored-by: Vasil Dimov <vd@FreeBSD.org>
It was copied verbatim from `CConnman::BindListenPort()` in the previous commit. Modernize its variables and style and log the error messages from the caller. Also categorize the informative messages to the "net" category because they are quite specific to the networking layer. Co-authored-by: Vasil Dimov <vd@FreeBSD.org>
AcceptConnection() is mostly copied from CConmann in net.cpp and will be modernized in the following commit. Co-authored-by: Vasil Dimov <vd@FreeBSD.org>
Co-authored-by: Vasil Dimov <vd@FreeBSD.org>
Socket handling methods are copied from CConnMan: `CConnman::GenerateWaitSockets()` goes to `SockMan::GenerateWaitSockets()`. `CConnman::ThreadSocketHandler()` and `CConnman::SocketHandler()` are combined into `SockMan::ThreadSocketHandler()`. `CConnman::SocketHandlerListening()` goes to `SockMan::SocketHandlerListening()`. Co-authored-by: Vasil Dimov <vd@FreeBSD.org>
`CConnman::SocketHandlerConnected()` copied to `SockMan::SocketHandlerConnected()`. Testing this requires adding a new feature to the SocketTestingSetup, inserting a "request" payload into the mock client that connects to us. Co-authored-by: Vasil Dimov <vd@FreeBSD.org>
Sockets-touching bits from `CConnman::SocketSendData()` copied to `SockMan::SendBytes()`. Testing this requires adding a new feature to the SocketTestingSetup, returning the DynSock I/O pipes from the mock socket so the received data can be checked. Co-authored-by: Vasil Dimov <vd@FreeBSD.org>
Copy from some parts of `CConnman::SocketHandlerConnected()` and `CConnman::ThreadSocketHandler()` to: `EventIOLoopCompletedForOne(id)` and `EventIOLoopCompletedForAll()`. Co-authored-by: Vasil Dimov <vd@FreeBSD.org>
Co-Authored-By: Christopher Coverdale <chris.coverdale24@gmail.com>
5a6d2b3 to
32e76bb
Compare
|
Last rebase before I'm going to split off the sv2 functionality into a fresh codebase. |
32e76bb to
d375647
Compare
|
Added a mutex for |
Co-Authored-By: Vasil Dimov <vd@FreeBSD.org>
d375647 to
6b8e3e6
Compare
|
This code is now part of https://github.com/Sjors/sv2-tp; feedback and pull requests are welcome there! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on:
Followed by #49. Parent PR #68
This PR introduces
Sv2Connman, a subclass ofSockMan(bitcoin#30988). It uses theSv2Transportintroduced in bitcoin#30315 to enable incoming connections from other Stratum v2 roles.It's main target user is the Template Provider role introduced in #49.
There may be other Stratum v2 roles we want to support in the future.
Earlier version(s): bitcoin#30332
Note to self, to keep this rebased until bitcoin#30988 lands (1 merge commits and 3 normal commits):
This won't include changes in the original branches. To achieve that:
Note that this code will most likely not be upstreamed to Bitcoin Core, but instead used to create a standalone c++ application that connects to a running node via an IPC interface. See bitcoin#31098.