Stratum v2 Template Provider common functionality #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 19, 2024
Closed
3cf779b to
b549fd6
Compare
6894e23 to
fc6ac1e
Compare
|
Updated to the latest interface changes proposed in bitcoin#30409 and #53. |
b549fd6 to
22d033c
Compare
491755c to
16d2381
Compare
4f957ee to
b69544c
Compare
ca73422 to
4fa25e0
Compare
|
Rebased for CMake |
|
One test still seems brittle: |
b69544c to
1ca68d2
Compare
1f720ff to
1912743
Compare
1ca68d2 to
b578e0a
Compare
598f08a to
436dc4d
Compare
|
Moved |
436dc4d to
46fa8f1
Compare
b578e0a to
489c9fb
Compare
7db898e to
765af74
Compare
7d5d5ad to
de05710
Compare
134d8b3 to
59f376b
Compare
de05710 to
21324f0
Compare
59f376b to
d4d57bc
Compare
|
CI fails because since bitcoin#29307 we have to |
b4abce4 to
6fda8e0
Compare
21324f0 to
b62f820
Compare
6fda8e0 to
5ff8c44
Compare
b62f820 to
5a6d2b3
Compare
5ff8c44 to
29a9c8c
Compare
|
Note to self for the next update, apply: diff --git a/src/sv2/template_provider.cpp b/src/sv2/template_provider.cpp
index a4331c6cb3..d83b86be69 100644
--- a/src/sv2/template_provider.cpp
+++ b/src/sv2/template_provider.cpp
@@ -66,7 +66,7 @@ Sv2TemplateProvider::Sv2TemplateProvider(interfaces::Mining& mining) : m_mining{
version_pubkey_bytes[1] = 0;
m_authority_pubkey = XOnlyPubKey(authority_key.GetPubKey());
std::copy(m_authority_pubkey.begin(), m_authority_pubkey.end(), version_pubkey_bytes.begin() + 2);
- LogInfo("Template Provider authority key: %s\n", EncodeBase58Check(version_pubkey_bytes));
+ LogPrintLevel(BCLog::SV2, BCLog::Level::Info, "Template Provider authority key: %s\n", EncodeBase58Check(version_pubkey_bytes));
LogTrace(BCLog::SV2, "Authority key: %s\n", HexStr(m_authority_pubkey)); |
5a6d2b3 to
32e76bb
Compare
29a9c8c to
0e01528
Compare
|
Last rebase before I'm going to split off the sv2 functionality into a fresh codebase. |
32e76bb to
d375647
Compare
0e01528 to
597513e
Compare
d375647 to
6b8e3e6
Compare
The template provider will listen for a Job Declarator client. It can establish a connection and detect various protocol errors. Co-Authored-By: Christopher Coverdale <chris.coverdale24@gmail.com> Co-Authored-By: Fi3
Co-authored-by: Christopher Coverdale <chris.coverdale24@gmail.com>
Incrementally update the template.
Co-authored-by: Vasil Dimov <vd@FreeBSD.org>
On by default. Allow Stratum v2 miners to opt out, pending more discussion on the BIP.
597513e to
ce5f206
Compare
|
This code is now part of https://github.com/Sjors/sv2-tp; feedback and pull requests are welcome there! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved from bitcoin#30475.
Based on:
And the following interface changes:
As well as:
-coinbaselocktime=0This contains all Template Provider functionality that can be used by both #68 and the IPC based sidecar alternative #48.