doc: Add missing tag:normaliz, fix quoting bug, update Sage CI (macOS arm64 testing)
#1205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hannes14 This change by itself does not fix the build failure; what am I missing? |
|
normaliz.lib (and probably sagbiNormaliz.lib) need features introduced in normaliz 3.10.0. |
|
or b15c1cf is missing |
|
This error shows up in a build of Singular without normaliz. |
74a8750 to
d2861f4
Compare
OK, I've rebased to latest spielwiese, and now it seems to work. |
|
Now that it gets farther, I see the following failures on about half of the tested platforms: |
tag:normaliztag:normaliz, fix quoting bug
|
OK, this fixed the docbuild for many platforms. |
|
On docker / linux (ubuntu-bionic-gcc_8, standard) Edit: Fixed by ce02149 |
|
On docker / linux (almalinux-9-python3.11, standard) Likewise on docker / linux (archlinux-latest, minimal) Edit: Fixed by e1bfa95 |
|
Build hangs on docker / linux (opensuse-tumbleweed-python3.10, minimal) |
e1bfa95 to
e5368ef
Compare
|
Rebased over latest spielwiese |
|
Each of the tested platforms brings some version of Perl. We don't test the specifics in the Sage configuration script |
|
All the remaining failing tests mention "macOs". Omitting the VSPACE interprocess communication may help: |
e5368ef to
a568853
Compare
For the record, all macOS tests here are on x86_64 and do not involve Docker. And the hangs mentioned here: #1205 (comment) do not involve macOS. They are openSUSE Rebased on latest spielwiese and waiting for updated tests now |
|
I put in a timelimit and made the build verbose to make it more visible what is hanging. On macOS: (https://github.com/Singular/Singular/actions/runs/7896994588/job/21552239487?pr=1205#step:10:9097) |
|
Thanks for the verbose output: the example with problems is the example from the section "Ssi links" which |
fe89eb7 to
2e7eadb
Compare
tag:normaliz, fix quoting bugtag:normaliz, fix quoting bug, update Sage CI (macOS arm64 testing)
|
Thanks! This gets us one step farther. https://github.com/Singular/Singular/actions/runs/7904829521/job/21577012664?pr=1205#step:10:8674 |
|
on https://github.com/Singular/Singular/actions/runs/7904829521/job/21577034497?pr=1205#step:11:6614 Edit: Fixed in 15a2fc4 |
|
on https://github.com/Singular/Singular/actions/runs/7904829521/job/21577017228?pr=1205#step:11:8284 Edit: Fixed as of 2d5d7e9 |
51a2279 to
cb6a0b3
Compare
|
The failure on opensuse-tumbleweed-minimal is some strange library problem (https://github.com/Singular/Singular/actions/runs/8060393602/job/22016967991?pr=1205#step:14:9643) Edit: Fixed in 15a2fc4 |
cb6a0b3 to
15a2fc4
Compare
|
Hang on linux (fedora-30, standard) Same hang on docker / linux (linuxmint-20.3, minimal) |
|
escape left brace: d967b40 |
15a2fc4 to
4a603cf
Compare
|
Thanks @hannes14, the "unescaped brace" warnings are gone now. But the hangs remain. They appear to be random, not specific to one of these systems. In this run the hang showed up on a different platform: docker / linux (linuxmint-20.2, standard) |
|
Also another likely random failure in macos / local-macos (13, xcode_15.0, homebrew-macos-usrlocal-standard) |
6 tasks
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 4, 2024
sagemathgh-37570: build/pkgs/singular: Update to 4.4.0 <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Includes - [x] Singular/Singular#1205 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> - Depends on sagemath#37492 URL: sagemath#37570 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 9, 2024
sagemathgh-37570: build/pkgs/singular: Update to 4.4.0 <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Includes - [x] Singular/Singular#1205 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> - Depends on sagemath#37492 URL: sagemath#37570 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 11, 2024
sagemathgh-37570: build/pkgs/singular: Update to 4.4.0 <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Includes - [x] Singular/Singular#1205 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> - Depends on sagemath#37492 URL: sagemath#37570 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 12, 2024
sagemathgh-37570: build/pkgs/singular: Update to 4.4.0 <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Includes - [x] Singular/Singular#1205 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> - Depends on sagemath#37492 URL: sagemath#37570 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 12, 2024
sagemathgh-37570: build/pkgs/singular: Update to 4.4.0 <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Includes - [x] Singular/Singular#1205 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> - Depends on sagemath#37492 URL: sagemath#37570 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix this build failure seen in https://github.com/Singular/Singular/actions/runs/7557525633/job/20577033209#step:11:4703