prefer cddlib/ over cdd/ #1064
Merged
prefer cddlib/ over cdd/ #1064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Having the "same" library twice on a system is asking for trouble. |
|
Thank you. It's a SageMath thing that sometimes system installs are rejected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An install from source of cdd will put the headers in
cddlib. So this location folder should be the default place to look for.Some systems put cdd in
usr/bin/cdd(e.g. ubuntu bionic). If I have installed an updated cdd somewhere else, it is difficult to link this other one.This patch will link the cdd installed from source anywhere, if it is early in my $PATH. I would argue that this is what I want in this case.
The downside is, that the system installed cdd will not be chosen anymore (depending on the system), if I also have a user installed cdd in my $PATH. (This could be fixed by enabling only one of
HAVE_CDDLIB_SETOPER_Hetc. according to the first element in my path with cdd.) However, this seems to be an unlikely scenario.