Add TypeForwardedTo pointing to BCL #291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evangelink
approved these changes
Jan 25, 2025
There was a problem hiding this comment.
This is fixing some issues we have noticed on MSTest and MTP products. Our initial idea was to do the following trick ourselves but @Youssef1313 found out that Roslyn is recommending to do this trick close to where you define the polyfill https://github.com/dotnet/roslyn/blob/main/docs%2Fcontributing%2Ftarget-framework-strategy.md#pattern-for-types
This should fix the problem in a global manner and transparently to your users.
|
wow. that is some impressive detetive work. |
|
i think u need to update your branch from remote |
|
oh wait. i forgot to push something. give me 10 min |
|
ok do a sync now |
|
this is now deployed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #290