Skip to content

Fix RBS to RBI signature translation for def nodes within sends #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 18, 2025

Conversation

Morriar
Copy link
Collaborator

@Morriar Morriar commented Jul 17, 2025

Closes #777.

Closes #777.

Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
@Morriar Morriar self-assigned this Jul 17, 2025
@Morriar Morriar requested a review from a team as a code owner July 17, 2025 19:42
@Morriar Morriar added the bugfix Fix a bug label Jul 17, 2025
Copy link
Contributor

@amomchilov amomchilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find

Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
@Morriar Morriar merged commit d4ffeb4 into main Jul 18, 2025
8 checks passed
@Morriar Morriar deleted the at-rbs-visibility branch July 18, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fix a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot translate rbi to rbs if there is a keyword before def
3 participants