Make translation of each kind of T assertions optional #771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
reviewed
Jun 19, 2025
| @@ -120,12 +147,16 @@ def t_annotation?(node) | |||
| return false unless t?(node.receiver) | |||
|
|
|||
| case node.name | |||
| when :let, :cast | |||
| return node.arguments&.arguments&.size == 2 | |||
| when :let | |||
There was a problem hiding this comment.
It feels a little odd to have these options checks as part of this method. This method intuitively checks if something is an annotation. The fact that the translate option is turned off doesn't make the thing not be an annotation anymore.
Would it require too much work to move this out? Or maybe we could have another method that calls this one called should_translate?. What do you think?
There was a problem hiding this comment.
The thing is I don't want to check twice on the name of the send.
I renamed the method translatable_annotation? instead.
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
ee3878a to
30c667b
Compare
vinistock
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default we translate everything.
It can be enabled/disabled separately: