Skip to content

Raise NotImplementedError from abstract methods #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2025
Merged

Raise NotImplementedError from abstract methods #766

merged 1 commit into from
Jun 13, 2025

Conversation

Morriar
Copy link
Collaborator

@Morriar Morriar commented Jun 13, 2025

No description provided.

@Morriar
Raise NotImplementedError from abstract methods
4973ccf 
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
@Morriar Morriar self-assigned this Jun 13, 2025
@Morriar Morriar requested a review from a team as a code owner June 13, 2025 21:06
@Morriar Morriar added the chore Chore task label Jun 13, 2025
jesse-shopify
jesse-shopify approved these changes Jun 13, 2025
View reviewed changes
Copy link
Contributor

@jesse-shopify jesse-shopify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Morriar Morriar merged commit fbf3478 into main Jun 13, 2025
8 checks passed
@Morriar Morriar deleted the at-rbs-abstract branch June 13, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juharris juharris juharris approved these changes

@jesse-shopify jesse-shopify jesse-shopify approved these changes

Assignees

@Morriar Morriar

Labels
chore Chore task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Morriar @juharris @jesse-shopify