Tests for simplifying and normalizing types in sigs during translation #754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation Requires RBI with Shopify/rbi#479
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
amomchilov
approved these changes
Jun 9, 2025
| def test_translate_to_rbs_with_nested_nilable_param | ||
| contents = <<~RB | ||
| Class.new do | ||
| sig { params(x: T.nilable(T.nilable(Integer))).void } |
There was a problem hiding this comment.
Is our logic for this purpose-built for RBS? This kind of normalization would be useful more generally. Would be nice to do: sig -> normalized sig -> RBS
There was a problem hiding this comment.
Yes it's exactly what we did: Shopify/rbi#479
Morriar
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for normalization / simplification / flattening of
T.nilableT.anyT.allRequires RBI with Shopify/rbi#479