Remove dead attr_reader: Spoom::Sorbet::Metrics::CodeMetricsVisitor::counters
#743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaanOzkan
approved these changes
May 26, 2025
There was a problem hiding this comment.
Looks dead indeed, instance variable isn't used externally, clients use the helper method collect_code_metrics which owns and supplies Counters instance instead of retrieving it from CodeMetricsVisitor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attr_reader appears to be unused and could be removed.
Before approving this pull-request, please double-check that it is indeed unused.
counterson GitHubIf this code is actually used, please add a comment explaining why and close this pull-request.
You can find more unused code in your project at: https://code.shopify.io/projects/shopify/spoom/code_removals/spoom
Note: closing this pull-request will mark the code as ignored and exclude it from future dead code detection.