Skip to content

Add callback conditions to deadcode to catch symbolic references to live methods in if: and unless: statements #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 19, 2025
Merged

Add callback conditions to deadcode to catch symbolic references to live methods in if: and unless: statements #738

merged 2 commits into from
May 19, 2025

Conversation

corsonknowles
Copy link
Contributor

@corsonknowles corsonknowles commented May 18, 2025 •
edited by egiurleo
Loading

Closes #727

Meant to address:

Adds bundle update because some lockfile gems are apparently no longer published.

@corsonknowles corsonknowles force-pushed the add_callback_condition_checks_to_deadcode branch from 70aeed8 to 5ee23b4 Compare May 18, 2025 10:11
@corsonknowles corsonknowles marked this pull request as ready for review May 18, 2025 10:14
@corsonknowles corsonknowles requested a review from a team as a code owner May 18, 2025 10:14
@corsonknowles corsonknowles mentioned this pull request May 18, 2025
Closed
@corsonknowles corsonknowles changed the title Add callback conditions to deadcode to catch symbolic references to live methods Add callback conditions to deadcode to catch symbolic references to live methods in if: and unless: statements May 18, 2025
egiurleo
egiurleo approved these changes May 19, 2025
View reviewed changes
Copy link
Contributor

@egiurleo egiurleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you very much!

@egiurleo
Copy link
Contributor

Ah CI is failing. Mind regenerating the spoom RBI file @corsonknowles?

@corsonknowles
Copy link
Contributor Author

I ran bundle exec spoom srb sigs export and committed the new line

@egiurleo egiurleo merged commit d9c319e into Shopify:main May 19, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egiurleo egiurleo egiurleo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deadcode includes methods referenced (called) as symbols
2 participants
@corsonknowles @egiurleo