Add RBI <> RBS translation of class helpers and generics #733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2d3c468 to
2faf81e
Compare
st0012
reviewed
May 14, 2025
vinistock
reviewed
May 15, 2025
|
Would it be possible to split this PR and have the framework for rewriting be separate? It will be much quicker to ship that part in isolation. |
Good point: #734 |
|
Rebased on top of #734. |
7d19cd5 to
287d56d
Compare
287d56d to
94d57fb
Compare
st0012
reviewed
May 20, 2025
test/spoom/cli/srb/tc_test.rb
Outdated
| @@ -213,6 +213,7 @@ def test_display_errors_with_limit_and_code_but_no_count | |||
|
|
|||
| def test_display_errors_from_path | |||
| @project = new_project | |||
| @project.bundle_install! | |||
There was a problem hiding this comment.
When pointing rbs to GH sources, I found that the these test projects weren't installing bundles correctly.
st0012
approved these changes
May 20, 2025
vinistock
reviewed
May 20, 2025
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a major rewrite of our current translator so we can also handle class annotations such as
@abstractand generic signatures.Sadly, to support generic translation we need to point to an unreleased version of RBS at the moment as we need
RBS::Parser.parse_type_params.I'd advise reviewing it commit by commit.