Skip to content

Handle RBS annotations on attribute signatures #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 9, 2025
Merged

Handle RBS annotations on attribute signatures #729

merged 2 commits into from
May 9, 2025

Conversation

Morriar
Copy link
Collaborator

@Morriar Morriar commented May 9, 2025

So we can go back and forth between RBS and RBI without loosing information:

T::Sig::WithoutRuntime.sig(:final) { overridable.override(allow_incompatible: true).returns(Integer) }
attr_accessor :foo

<>

# @without_runtime
# @final
# @override(allow_incompatible: true)
# @overridable
#: Integer
attr_accessor :foo

@Morriar
Handle RBS annotations on attribute signatures
c158540 
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
@Morriar Morriar requested a review from a team as a code owner May 9, 2025 18:03
@Morriar Morriar self-assigned this May 9, 2025
@Morriar Morriar added the feature New feature label May 9, 2025
@Morriar
Update exported RBI
b9be5d0 
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
@Morriar Morriar merged commit c70bb10 into main May 9, 2025
8 checks passed
@Morriar Morriar deleted the at-rbs-annotations-attrs branch May 9, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinistock vinistock vinistock approved these changes

Assignees

@Morriar Morriar

Labels
feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Morriar @vinistock