Skip to content

Translate @without_runtime <> T::Sig::WithoutRuntime.sig #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 8, 2025
Merged

Translate @without_runtime <> T::Sig::WithoutRuntime.sig #728

merged 3 commits into from
May 8, 2025

Conversation

Morriar
Copy link
Collaborator

@Morriar Morriar commented May 8, 2025

When using spoom srb sigs translate --from rbi --to rbs, this RBI:

T::Sig::WithoutRuntime.sig { void }
def foo; end

will be translated to this RBS:

# @without_runtime
#: -> void
def foo; end

then with spoom srb sigs translate --from rbs --to rbi, back to:

T::Sig::WithoutRuntime.sig { void }
def foo; end

Morriar added 2 commits May 8, 2025 17:20
@Morriar
Bump rbi to v0.3.3
4e083aa 
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
@Morriar
Handle translation of @without_runtime methods
6463c63 
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
@Morriar Morriar requested a review from egiurleo May 8, 2025 21:26
@Morriar Morriar self-assigned this May 8, 2025
@Morriar Morriar requested a review from a team as a code owner May 8, 2025 21:26
@Morriar Morriar added the feature New feature label May 8, 2025
@Morriar Morriar enabled auto-merge May 8, 2025 21:28
paracycle
paracycle reviewed May 8, 2025
View reviewed changes
@Morriar
Bump minimum version for rbi to v0.3.3
820392b 
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
@Morriar Morriar merged commit 149a5ab into main May 8, 2025
8 checks passed
@Morriar Morriar deleted the at-rbs-without-runtime branch May 8, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paracycle paracycle paracycle approved these changes

@egiurleo egiurleo Awaiting requested review from egiurleo

Assignees

@Morriar Morriar

Labels
feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Morriar @paracycle